En la página de configuración de MyQuill, la imagen `{$myquill_logo}`

javieradmin

Hi all,

Refactoring module code for PrestaShop 1.7.7.8 (PHP 8.2) regarding: En la página de configuración de MyQuill, la imagen {$myquill_logo} falla al cargar, activando el mecanismo de respaldo (onerror). No obstante, el elemento de respaldo <span class="mq-mark">Q</span> o no aparece o está incorrectamente estilizado, a pesar de que el atributo onerror le aplica display:flex..

In myquill/views/templates/admin/configure.tpl we have this snippet:

<div id="myquillConfiguration">
    <div class="mq-chrome">
        <div class="mq-brand">
            <img class="mq-logo" src="{$myquill_logo|escape:'html':'UTF-8'}" alt="" onerror="this.style.display='none'; this.nextElementSibling.style.display='flex';" />
            <span class="mq-mark" style="display:none;">Q</span>
            <div class="mq-brand-copy">
                <strong>{$myquill_display_name|escape:'html':'UTF-8'}</strong>
                <span class="mq-version">v{$myquill_version|escape:'html':'UTF-8'}</span>

What is the cleanest way to adapt this for PrestaShop 9 while maintaining strict typing and PSR standards?

inma_9689

PrestaShop 9 with PHP 8.2 strictly enforces return types on overrides. Hit the same deprecation issue recently.

Milo

Hi @javieradmin!

In PrestaShop PrestaShop 1.7.7.8, this stems from template block inheritance and variable scoping in Smarty.

Here is the corrected template snippet for myquill/views/templates/admin/configure.tpl:

{if isset($cart) && $cart && !empty($cart->id)}
  <div class="custom-module-block-fee alert alert-info">
    {l s='Additional handling option active' d='Modules.Custom'}
  </div>
{/if}

This renders the block cleanly. To avoid modifying theme templates directly, take a look at reemplazar el TinyMCE predeterminado por el editor moderno Quill.

javieradmin

Installed the module and configured it in a few minutes. Works exactly as needed on PrestaShop 1.7.7.8. Thanks a ton @Milo!